feat: access module #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update imports
ashitakah
requested changes
Nov 7, 2024
solidity/contracts/modules/accessControl/ModuleAccessController.sol
Outdated
Show resolved
Hide resolved
Merged
0xJabberwock
reviewed
Nov 7, 2024
Comment on lines
8
to
9
| abstract contract AccessControllerModule is AccessController, Module { | ||
| abstract contract ModuleAccessController is CommonAccessController, Module { |
There was a problem hiding this comment.
I was doubting whether ModuleAccessController should inherit from Module, as it is not the module itself, and had a breaking idea: why not migrate it to prophet-core and make Module inherit from it, such that:
Oracle is OracleAccessController, whileModule is ModuleAccessControllerandMyAccessModule is Module?
There was a problem hiding this comment.
I feel the same about ModuleAccessController inheriting from Module. The need to extend Module comes from the necessity of accessing the ORACLE immutable variable, which is actually define in Validator, from which Module extends.
I like the suggestion, but I'd add it in a future, smaller PR to unblock the current chain of PRs.
solidity/contracts/modules/accessControl/ModuleAccessController.sol
Outdated
Show resolved
Hide resolved
solidity/contracts/modules/accessControl/ModuleAccessController.sol
Outdated
Show resolved
Hide resolved
0xJabberwock
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-515